GN-126: Gate Gravity behind auth landing page #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add landing auth gate with invariants: signed-out sees landing, signed-in sees app - adapt handlers/adapters to construct at edges: mpr-ui auth + per-test harness isolation - remove interior defensive checks (shared harness globals) to prevent test flakes - wrap errors with operation+subject+stable code (e.g., mpr_ui.load_failed) - CI: go vet/staticcheck | ineffassign | npm test | make ci passing
… validation to edge - add LandingAuthAttributes invariants: base/login/logout/nonce attributes set from runtime config - adapt landing login wiring to construct attributes at bootstrap edge - remove interior defensive checks (n/a) - wrap errors with operation+subject+stable code (n/a) - CI: make test, make lint, make ci passing
…onfig edge - add static mpr-ui bundle tag and template mounts for auth elements - adapt bootstrap to mount auth elements after runtime config + tauth load - remove dynamic mpr-ui loader to avoid pre-init attributes - wrap errors with operation+subject+stable code (unchanged) - CI: make test | make lint | make ci passing
…dation to edge - add MprUiCdnAssets with invariants: mpr-ui css/js use @latest CDN tag - adapt handlers/adapters to construct at edges (update CDN mirror patterns) - remove interior defensive checks (validated once at boundary) (not applicable) - wrap errors with operation+subject+stable code (unchanged) - CI: make test | make lint | make ci passing
…edge - add runtime googleClientId override with invariant: non-empty string - adapt runtime config JSON + harness payloads to supply client id - keep validation at runtime-config boundary; no new interior checks - emit stable error code for invalid client id (app_config.invalid_google_client_id) - CI: make test/make lint/make ci, tsc --noEmit passing
- add frontend/config.yaml with per-origin auth settings - load mpr-ui config before bundle and remove manual auth wiring - enforce strict auth boot via config loader promise - CI: make lint passing; make test/make ci killed by sandbox
- wait for DOMContentLoaded before config load - init tauth + prime nonce prior to loading mpr-ui.js - CI: make lint passing; make test killed by sandbox
- mirror mpr-ui demo proxy routes and origin lists - expand CORS + tenant origin placeholders in config.tauth.yml - CI: make lint passing; make test killed by sandbox
…tion Added auth operation chaining to prevent race conditions when concurrent auth events (authenticated/unauthenticated) interleave during async operations like IndexedDB hydration. Previously, rapid auth state changes could cause activeStorageKey to change during hydrateActiveScope(), leading to a mismatch when ensureHydrated() was called and throwing 'storage.notes.not_ready' error. Changes: - Added authOperationChain (Promise) to serialize auth operations - Added authOperationId (number) to track and cancel stale operations - Modified handleAuthAuthenticated to chain operations and check ID - Modified handleAuthUnauthenticated with same pattern Tests: node --test tests/auth.operationChain.test.js (9 tests) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Updates mpr-ui CDN references from @latest to @v3.6.2 which includes the MU-132 fix for dispatching authenticated event after credential exchange. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ation tests - Remove authenticatedCount checks that required mpr-ui callback firing - Use waitForSyncManagerUser to verify authentication completion - Set initialProfile in TAuth harness to match expected test users - Update UI tests to use prepareFrontendPage for proper auth flow - Add skipAppReady option for landing page tests - Set default 5-second timeouts for auth wait functions - Refactor test harness to properly coordinate session cookies - Add page-separation architecture (app.html + index.html) - Delete legacy auth modules (auth.js, tauthSession.js, authControls.js) - Add profileNormalization utility for TAuth/mpr-ui profile mapping Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- remove standalone fullscreen control and styling - update menu toggle state handling with prefixed fullscreen events - add Playwright coverage for menu-only toggle and webkit fallback - CI: make test, make lint, make ci
…i-config GN-446: Adopt mpr-ui config.yaml loader
…-cdn GN-442: Load tauth.js from CDN
…ge-indexeddb Fix GN-439 IndexedDB persistence
…me-google-client-id feat(frontend): allow runtime google client id override; validate at edge
…mpr-ui-latest feat(frontend): introduce MprUiCdnAssets smart constructor; move validation to edge
…mpr-ui-static-loader feat(frontend): introduce mpr-ui static loader; move auth wiring to config edge
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d81cbf2b33
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- add puppeteer login E2E + fullscreen menu regression; remove playwright test/dependency - update CI to install Puppeteer only and extend per-file timeout for auth.login - validation moved to edges: n/a (test-only change) - errors wrapped with operation+subject+stable code: n/a - CI: make ci passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing