GN-442: Load tauth.js from CDN #190
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add landing auth gate with invariants: signed-out sees landing, signed-in sees app - adapt handlers/adapters to construct at edges: mpr-ui auth + per-test harness isolation - remove interior defensive checks (shared harness globals) to prevent test flakes - wrap errors with operation+subject+stable code (e.g., mpr_ui.load_failed) - CI: go vet/staticcheck | ineffassign | npm test | make ci passing
… validation to edge - add LandingAuthAttributes invariants: base/login/logout/nonce attributes set from runtime config - adapt landing login wiring to construct attributes at bootstrap edge - remove interior defensive checks (n/a) - wrap errors with operation+subject+stable code (n/a) - CI: make test, make lint, make ci passing
…onfig edge - add static mpr-ui bundle tag and template mounts for auth elements - adapt bootstrap to mount auth elements after runtime config + tauth load - remove dynamic mpr-ui loader to avoid pre-init attributes - wrap errors with operation+subject+stable code (unchanged) - CI: make test | make lint | make ci passing
…dation to edge - add MprUiCdnAssets with invariants: mpr-ui css/js use @latest CDN tag - adapt handlers/adapters to construct at edges (update CDN mirror patterns) - remove interior defensive checks (validated once at boundary) (not applicable) - wrap errors with operation+subject+stable code (unchanged) - CI: make test | make lint | make ci passing
…edge - add runtime googleClientId override with invariant: non-empty string - adapt runtime config JSON + harness payloads to supply client id - keep validation at runtime-config boundary; no new interior checks - emit stable error code for invalid client id (app_config.invalid_google_client_id) - CI: make test/make lint/make ci, tsc --noEmit passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary\n- load tauth.js from a configurable CDN (tauthScriptUrl) and stop proxying /tauth.js through gHTTP\n- plumb tauthScriptUrl through runtime config, app loader, and test harnesses\n- rename env templates to env..example and keep .env files untracked\n- update gHTTP dev/docker compose wiring for HTTPS on :4443\n- refresh docs/changelog for the new auth/runtime setup\n\n## Testing\n- make test