MDEV-38327 Do not use rowid filter when switching to index merge #4541
+206
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mariadb-YuchenPei
force-pushed
the
bb-11.4-mdev-38327
branch
from
db20eaf to
31169f9
Compare
factor out common index merge checks of quick select types
Index merge and rowid filter should not be used together, however, even if index merge is not chosen earlier in best_access_path, it may be chosen again in make_join_select. Therefore this patch ensures that rowid filter is not used when index merge is chosen in make_join_select. Apart from index merge, the only other possible quick select inside ref_to_range is range, and we disable rowid filter in this situation too.
mariadb-YuchenPei
force-pushed
the
bb-11.4-mdev-38327
branch
from
31169f9 to
d3143e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index merge and rowid filter should not be used together, however, even if index merge is not chosen earlier in best_access_path, it may be chosen again in make_join_select. Therefore this patch ensures that rowid filter is not used when index merge is chosen in make_join_select.