Skip to content

Fix MDEV-39207 test (skip if ha_example is not built)#5181

Merged
sanja-byelkin merged 1 commit into
10.11from
10.11-MDEV-39207-fix
Jun 4, 2026
Merged

Fix MDEV-39207 test (skip if ha_example is not built)#5181
sanja-byelkin merged 1 commit into
10.11from
10.11-MDEV-39207-fix

Conversation

@sanja-byelkin
Copy link
Copy Markdown
Member

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the session_track_system_variables_basic.test test file to include the have_example_plugin.inc source file, ensuring the example plugin is available for the test execution. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures the sys_vars test session_track_system_variables_basic.test is skipped when the ha_example (EXAMPLE) plugin is not built/available, preventing failures in configurations where $HA_EXAMPLE_SO is unset.

Changes:

  • Add --source include/have_example_plugin.inc to gate the test on availability of the EXAMPLE plugin.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sanja-byelkin sanja-byelkin enabled auto-merge (rebase) June 4, 2026 16:02
@sanja-byelkin sanja-byelkin merged commit d58b379 into 10.11 Jun 4, 2026
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants