Update TLS test regexes for OpenSSL 4.0 error message changes#5186
Open
ottok wants to merge 1 commit into
Open
Update TLS test regexes for OpenSSL 4.0 error message changes#5186ottok wants to merge 1 commit into
ottok wants to merge 1 commit into
Conversation
OpenSSL 4.0 changed TLS alert error messages from "ssl/tls alert ..." to
"tls alert ...", causing main.ssl_crl and main.tlsv13 to fail with
result mismatches like:
-ERROR 2026 (HY000): TLS/SSL error: ssl/tls alert handshake failure
-ERROR 2026 (HY000): TLS/SSL error: ssl/tls alert handshake failure
+ERROR 2026 (HY000): TLS/SSL error: tls alert handshake failure
+ERROR 2026 (HY000): TLS/SSL error: tls alert handshake failure
Update the `--replace_regex` patterns in both tests to accept the new
"tls alert" variant alongside the existing "sslv3" and "ssl/tls"
formats, normalizing them to the expected "ssl/tls" output so the
result files remain valid across OpenSSL versions.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the regular expression replacements in the test files mysql-test/main/ssl_crl.test and mysql-test/main/tlsv13.test to accommodate different TLS/SSL alert formats, specifically matching 'sslv3', 'ssl/tls', or 'tls' alerts. There are no review comments provided, so I have no feedback to offer.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL 4.0 changed TLS alert error messages from "ssl/tls alert ..." to "tls alert ...", causing main.ssl_crl and main.tlsv13 to fail with result mismatches like:
Update the
--replace_regexpatterns in both tests to accept the new "tls alert" variant alongside the existing "sslv3" and "ssl/tls" formats, normalizing them to the expected "ssl/tls" output so the result files remain valid across OpenSSL versions.This targets 10.6 because #5029 (about https://jira.mariadb.org/browse/MDEV-39509) was also submitted for 10.6.