Skip to content

MDEV-39870: macOSB Build Warning on Typecast #5189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DaveGosselin-MariaDB wants to merge 1 commit into
base: 10.11
Choose a base branch
from
+10 −1
Open

MDEV-39870: macOSB Build Warning on Typecast #5189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion sql/sql_class.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3289,7 +3289,16 @@ class THD: public THD_count, /* this must be first */
void reset(THD *thd)
{
tv_sec= thd->query_start();
tv_usec= (long) thd->query_start_sec_part();

/*
The type of tv_usec depends on the system and on macOS
it is __darwin_suseconds_t. Using decltype is system
agnostic because its result is whatever the underlying
type of tv_usec is. This should be more portable than
assuming that the left hand side is (long) (the previous
cast value).
*/
tv_usec= static_cast<decltype(tv_usec)>(thd->query_start_sec_part());
}
} start_time;

Expand Down