#4359 Add source generator for data portal operation dispatch#4816
Merged
rockfordlhotka merged 5 commits intomainfrom Feb 7, 2026
Merged
#4359 Add source generator for data portal operation dispatch#4816rockfordlhotka merged 5 commits intomainfrom
rockfordlhotka merged 5 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a source generator that creates IDataPortalOperationMapping implementations for business types with data portal operation methods, eliminating the need for reflection-based invocation and enabling AOT trimming compatibility. - New generator project: Csla.Generator.DataPortalInterfaces.CSharp - New IDataPortalOperationMapping interface and DataPortalOperationNotSupportedException - DataPortalTarget tries generated dispatch first, falls back to reflection - Handles all 13 operation attributes, [Inject], overloads, async, nested classes - 13 snapshot tests covering all scenarios, full test suite passes with 0 regressions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…only Remove standalone NuGet packaging (PackageId, IsPackable=true, Pack items) so the generator is distributed exclusively via the Csla package, not as a separate NuGet package. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace fixed Task.Delay(500) with polling loop that checks dashboard state every 50ms with a 5s timeout, avoiding race with timer callbacks on busy CI servers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rockfordlhotka
requested review from
JasonBock
and removed request for
JasonBock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on #4359
Summary
Csla.Generator.DataPortalInterfaces.CSharp) that generates explicitIDataPortalOperationMappingimplementations, eliminating reflection-based method dispatch in the data portalIDataPortalOperationMappinginterface and integrates it intoDataPortalTargetwith fallback to existing reflection-based dispatchTest plan
🤖 Generated with Claude Code