Skip to content

ProjectTracker: lift TimeStamp into intermediate base classes #4859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rockfordlhotka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ProjectTracker: lift TimeStamp into intermediate base classes #4859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Samples/ProjectTracker/ProjectTracker.BusinessLibrary/Admin/RoleEdit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
namespace ProjectTracker.Library.Admin
{
[CslaImplementProperties]
public partial class RoleEdit : BusinessBase<RoleEdit>
public partial class RoleEdit : CslaBaseTypes.BusinessBase<RoleEdit>
{
public RoleEdit()
{
Expand All @@ -19,10 +19,6 @@ public RoleEdit()
[Required]
public partial string Name { get; set; }

[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public partial byte[] TimeStamp { get; set; }

protected override void AddBusinessRules()
{
base.AddBusinessRules();
Expand Down
15 changes: 14 additions & 1 deletion Samples/ProjectTracker/ProjectTracker.BusinessLibrary/CslaBaseTypes/BusinessBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,23 @@
using System;
using System;
using System.ComponentModel;
using Csla;

namespace ProjectTracker.Library.CslaBaseTypes
{
[Serializable]
public abstract class BusinessBase<T> : Csla.BusinessBase<T> where T : Csla.BusinessBase<T>
{
public static readonly PropertyInfo<byte[]> TimeStampProperty =
RegisterProperty<byte[]>(nameof(TimeStamp));

[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
#pragma warning disable CSLA0007 // null-forgiving on GetProperty matches framework convention for non-nullable managed properties
public byte[] TimeStamp
{
get => GetProperty(TimeStampProperty)!;
set => SetProperty(TimeStampProperty, value);
}
#pragma warning restore CSLA0007
}
}
13 changes: 13 additions & 0 deletions Samples/ProjectTracker/ProjectTracker.BusinessLibrary/CslaBaseTypes/BusinessDocumentBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
using System;
using System.ComponentModel;
using Csla;

namespace ProjectTracker.Library.CslaBaseTypes
{
Expand All @@ -7,6 +9,17 @@ public abstract class BusinessDocumentBase<T, C> : Csla.BusinessDocumentBase<T,
where T : Csla.BusinessDocumentBase<T, C>
where C : notnull, Csla.Core.IEditableBusinessObject
{
public static readonly PropertyInfo<byte[]> TimeStampProperty =
RegisterProperty<byte[]>(nameof(TimeStamp));

[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
#pragma warning disable CSLA0007 // null-forgiving on GetProperty matches framework convention for non-nullable managed properties
public byte[] TimeStamp
{
get => GetProperty(TimeStampProperty)!;
set => SetProperty(TimeStampProperty, value);
}
#pragma warning restore CSLA0007
}
}
4 changes: 0 additions & 4 deletions Samples/ProjectTracker/ProjectTracker.BusinessLibrary/ProjectEdit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ namespace ProjectTracker.Library
[CslaImplementProperties]
public partial class ProjectEdit : CslaBaseTypes.BusinessDocumentBase<ProjectEdit, ProjectResourceEdit>
{
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public partial byte[] TimeStamp { get; private set; }

[Display(Name = "Project id")]
public partial int Id { get; private set; }

Expand Down
6 changes: 1 addition & 5 deletions Samples/ProjectTracker/ProjectTracker.BusinessLibrary/ProjectResourceEdit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,8 @@
namespace ProjectTracker.Library
{
[CslaImplementProperties]
public partial class ProjectResourceEdit : BusinessBase<ProjectResourceEdit>
public partial class ProjectResourceEdit : CslaBaseTypes.BusinessBase<ProjectResourceEdit>
{
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public partial byte[] TimeStamp { get; set; }

[Display(Name = "Resource id")]
public partial int ResourceId { get; private set; }

Expand Down
6 changes: 1 addition & 5 deletions Samples/ProjectTracker/ProjectTracker.BusinessLibrary/ResourceAssignmentEdit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,8 @@
namespace ProjectTracker.Library
{
[CslaImplementProperties]
public partial class ResourceAssignmentEdit : BusinessBase<ResourceAssignmentEdit>
public partial class ResourceAssignmentEdit : CslaBaseTypes.BusinessBase<ResourceAssignmentEdit>
{
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public partial byte[] TimeStamp { get; set; }

[Display(Name = "Project id")]
public partial int ProjectId { get; private set; }

Expand Down
4 changes: 0 additions & 4 deletions Samples/ProjectTracker/ProjectTracker.BusinessLibrary/ResourceEdit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ namespace ProjectTracker.Library
[CslaImplementProperties]
public partial class ResourceEdit : CslaBaseTypes.BusinessDocumentBase<ResourceEdit, ResourceAssignmentEdit>
{
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public partial byte[] TimeStamp { get; set; }

[Display(Name = "Resource id")]
public partial int Id { get; set; }

Expand Down