Add support for configuring socket_timeout in SCP mode#423
Open
kyatsen wants to merge 1 commit intoMarketSquare:masterfrom
Open
Add support for configuring socket_timeout in SCP mode#423kyatsen wants to merge 1 commit intoMarketSquare:masterfrom
kyatsen wants to merge 1 commit intoMarketSquare:masterfrom
Conversation
This commit allows to pass socket_timeout argument to SCPClient constructor. It's add a flexibiliy when the connection is not stable and default 10 second timeout is not enough.
Author
|
This commit fixes this issue: #397 So it would be cool to merge it. |
Member
|
Hi, sorry for the late reply. For reasons I had to merge a big refactoring removing Python2 & Jython support. The refactoring clashes with your changes. I think, they should quite easily be integrated in to the Could sync your branch (or do the changes fresh)? I saw you documented the new parameter. Thanks a lot!! Could you also add some basic test case(s)? For verification? Thanks a lot!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows to pass socket_timeout argument to SCPClient constructor. It's add a flexibiliy when the connection is not stable and default 10 second timeout is not enough.