Fix: Search for session marker at file beginning instead of end#29
Open
mzdbxqh wants to merge 1 commit intoMartian-Engineering:mainfrom
Open
Fix: Search for session marker at file beginning instead of end#29mzdbxqh wants to merge 1 commit intoMartian-Engineering:mainfrom
mzdbxqh wants to merge 1 commit intoMartian-Engineering:mainfrom
Conversation
The find_jsonl_by_marker() function was reading the last 50KB of JSONL files to find session markers, but markers are written at session start and appear at the beginning of the file. For long-running workers that generate >50KB of logs, the marker would be outside the search window, causing session discovery to fail. This fix changes the search to read the first 50KB instead, where the marker is actually located.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The find_jsonl_by_marker() function was reading the last 50KB of JSONL files to find session markers, but markers are written at session start and appear at the beginning of the file.
For long-running workers that generate >50KB of logs, the marker would be outside the search window, causing session discovery to fail.
This fix changes the search to read the first 50KB instead, where the marker is actually located.