Update of the BAFG spectral data#392
Open
olessmn wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear MassBank Team,
I would like to update the BAFG spectral data on MassBank.
This pull request includes:
Additional information:
Since August 2025, we regularly publish our spectral database on Zenodo (https://zenodo.org/records/20426911). This database (Collective Spectral Library; CSL) is a collaborative effort involving currently five laboratories in Germany.
I developed a package (https://github.com/bafg-bund/csl-tools) to export the spectral data of our database in the MassBank-format.
The version of the database and the package is written into the file, for example:
MS$DATA_PROCESSING: COMMENT Export with csl-tools 1.1.0 and CSL_v26.2.As we are constantly curating and correcting our records, it is easiest to regenerate all TXT files when exporting our records for MassBank. Therefore, the content of the TXT files may change; however, the file name (and accession ID) will remain unchanged.
Validator
This time I used your validator to correct issues before my pull request ;) (It helped a lot).
Only the following issue is left:
In this case, we think that
[C18H19BrN6O5]-is correct, as the compound was indeed measured at[M]-.Questions
CC BY 4.0for the fieldLICENSE:, therefore we usedCC BY. We would prefer adding the version (if possible). Or is there a reason for that?ChemOntinformation to all records (e.g.:CH$LINK: ChemOnt CHEMONTID:0000331; Organic compounds; [...]I couldn't find that ChemOnt database, and didn't know how to integrate this information into our export tool. It is totally ok, if you can add it to the records, but then you may have to do it for every update (as our txt-files are regenerated).
Please let me know if the contribution requires further adjustments.
Thank you!
Best regards,
Ole