Skip to content

Use inherits and format-util for smaller bundle size #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nolanlawson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use inherits and format-util for smaller bundle size #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/checks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
* Licensed under the MIT license.
*/

var util = require('util');
var format = require('format-util');

var errors = module.exports = require('./errors');

function failCheck(ExceptionConstructor, callee, messageFormat, formatArgs) {
messageFormat = messageFormat || '';
var message = util.format.apply(this, [messageFormat].concat(formatArgs));
var message = format.apply(this, [messageFormat].concat(formatArgs));
var error = new ExceptionConstructor(message);
Error.captureStackTrace(error, callee);
throw error;
Expand Down
4 changes: 2 additions & 2 deletions lib/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Licensed under the MIT license.
*/

var util = require('util');
var inherits = require('inherits');

function IllegalArgumentError(message) {
Error.call(this, message);
Expand All @@ -17,7 +17,7 @@ function IllegalStateError(message) {
Error.call(this, message);
this.message = message;
}
util.inherits(IllegalStateError, Error);
inherits(IllegalStateError, Error);

IllegalStateError.prototype.name = 'IllegalStateError';

Expand Down
60 changes: 35 additions & 25 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,37 @@
{
"name": "precond",
"description": "Precondition checking utilities.",
"version": "0.2.3",
"author": "Mathieu Turcotte <turcotte.mat@gmail.com>",
"keywords": ["precondition", "assert", "invariant", "contract", "condition"],
"license": "MIT",
"repository": {
"type": "git",
"url": "https://github.com/MathieuTurcotte/node-precond.git"
},
"devDependencies": {
"nodeunit": "0.9",
"jshint": "2.5"
},
"scripts": {
"pretest": "node_modules/.bin/jshint lib/ examples/ index.js",
"test": "node_modules/.bin/nodeunit tests/"
},
"engines": {
"node": ">= 0.6"
},
"files": [
"index.js",
"lib"
]
"name": "precond",
"description": "Precondition checking utilities.",
"version": "0.2.3",
"author": "Mathieu Turcotte <turcotte.mat@gmail.com>",
"keywords": [
"precondition",
"assert",
"invariant",
"contract",
"condition"
],
"license": "MIT",
"repository": {
"type": "git",
"url": "https://github.com/MathieuTurcotte/node-precond.git"
},
"devDependencies": {
"nodeunit": "0.9",
"jshint": "2.5"
},
"scripts": {
"pretest": "node_modules/.bin/jshint lib/ examples/ index.js",
"test": "node_modules/.bin/nodeunit tests/"
},
"engines": {
"node": ">= 0.6"
},
"files": [
"index.js",
"lib"
],
"dependencies": {
"format-util": "^1.0.3",
"inherits": "^2.0.3"
}
}