Added token verification and signing for login #908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tegefaulkes
suggested changes
Jun 18, 2025
Contributor
tegefaulkes
left a comment
tegefaulkes
left a comment
There was a problem hiding this comment.
Small thing to point out but otherwise fine.
Contributor
Author
|
This PR looks good to go now. Merging. |
Contributor
Author
|
As discussed with roger, the functionality will be merged first to avoid blocking PKE work, then I will write tests in another PR later. |
chore: cleaned up code
aryanjassal
force-pushed
the
feature-polykey-auth-login
branch
from
a93d668 to
75ccca7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a protocol for taking in a signed JWT, verifying it, then adding additional data and returning the data alongside the original token back to the caller.
This is used in a protocol to securely provide identity proof to a platform. This is not used to access any protected resources like granting RPC access.
Issues Fixed
polykey auth logincommand Polykey-CLI#408Tasks
AuthSignTokenRPC methodsFinal checklist