Fix pino-pretty dependency issue with graceful fallback#14
Draft
Fix pino-pretty dependency issue with graceful fallback#14
Conversation
Co-authored-by: MatthewSH <3768988+MatthewSH@users.noreply.github.com>
Co-authored-by: MatthewSH <3768988+MatthewSH@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix the issue outlined in @MatthewSH/rivalsjs/issues/10
Fix pino-pretty dependency issue with graceful fallback
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
Problem
The library was failing when
pino-prettywas not available with the error:This occurred because the logger configuration in
src/logger.tswas hardcoded to usepino-prettyas a transport in non-production environments, butpino-prettywas only listed as a devDependency. This meant:pino-prettyby defaultNODE_ENVwasn't set to "production"Solution
Modified the logger configuration to gracefully handle when
pino-prettyis not available:getTransportConfig()helper function that usesrequire.resolve()to check ifpino-prettyis availablepino-prettyis not foundpino-prettyis availableTesting
Verified the fix works in all scenarios:
Without pino-pretty:
With pino-pretty:
This ensures the library works reliably regardless of whether users have
pino-prettyinstalled, while still providing a better development experience when it's available.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.