[FEATURE] Added TYPO3 14 support, added functional and unit tests#2
Merged
[FEATURE] Added TYPO3 14 support, added functional and unit tests#2
Conversation
384c6b7 to
0e74a8a
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds TYPO3 14 support and introduces comprehensive test coverage for the extension, while dropping PHP 8.1 support.
Changes:
- Updated minimum PHP version from 8.1 to 8.2
- Added TYPO3 v14 support alongside existing v12 and v13 compatibility
- Added comprehensive unit and functional test suites covering core functionality
Reviewed changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updated PHP requirement to 8.2+, added TYPO3 14 support, bumped phpstan version |
| Tests/Unit/Request/FrontendRequestTest.php | New unit tests for frontend request functionality |
| Tests/Unit/PageParser/Service/UrlServiceTest.php | New unit tests for URL service operations |
| Tests/Unit/PageParser/ParserCollectorTest.php | New unit tests for parser collector behavior |
| Tests/Unit/PageParser/Parser/UrlParserTest.php | New unit tests for URL parser |
| Tests/Unit/PageParser/Parser/TitleParserTest.php | New unit tests for title extraction |
| Tests/Unit/PageParser/Parser/MetadataParserTest.php | New unit tests for metadata parsing |
| Tests/Unit/PageParser/Parser/LocaleParserTest.php | New unit tests for locale detection |
| Tests/Unit/PageParser/Parser/BodyParserTest.php | New unit tests for body content extraction |
| Tests/Unit/PageParser/PageParserTest.php | New unit tests for page parser aggregation |
| Tests/Unit/Handler/RequestHandlerTest.php | New unit tests for request handling |
| Tests/Unit/Event/ModifyUrlEventTest.php | New unit tests for URL modification event |
| Tests/Unit/Event/ModifyRequestEventTest.php | New unit tests for request modification event |
| Tests/Unit/Dto/RequestResultTest.php | New unit tests for request result DTO |
| Tests/Unit/Dto/RequestParametersTest.php | New unit tests for request parameters DTO |
| Tests/Unit/Dto/RequestErrorTest.php | New unit tests for request error DTO |
| Tests/Unit/Dto/RequestContextTest.php | New unit tests for request context DTO |
| Tests/Unit/Controller/RequestControllerTest.php | New unit tests for request controller |
| Tests/Unit/Builder/RequestParametersBuilderTest.php | New unit tests for parameters builder |
| Tests/Functional/PageParser/ParserCollectorTest.php | New functional tests for parser DI integration |
| CHANGELOG.md | Documents TYPO3 14 support, test additions, and PHP 8.1 removal |
| Build/phpunit/UnitTests.xml | New PHPUnit configuration for unit tests |
| Build/phpunit/FunctionalTests.xml | New PHPUnit configuration for functional tests |
| Build/Scripts/runTests.sh | Updated for TYPO3 14, removed v11 support, updated extension name reference |
| .github/workflows/tests.yml | Added TYPO3 14 testing (experimental), enabled unit/functional test runs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0e74a8a to
2f90d4b
Compare
Collaborator
Author
|
Tests failing because of a security advisor for |
|
Please re-run tests again (https://news.typo3.com/article/typo3-1411-13426-and-12443-maintenance-releases-published) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
runTests.shexperimentalbecausephpstan-typo3is not yet compatible with 14These changes are necessary to have v14 support for
yoast-seo-for-typo3/yoast-seo.Testing
Functionally nothing has / needed to changed so the unit and functional tests could be reviewed.