Open
Conversation
I've seen that it has issues with R6 (really weird movement) and after tinkering, I couldn't find anything that could fix it. So next thing I've done was to add backwards compatibility and it worked out well. Now both R15 and R6 work in harmony :D Another thing I've done was to make left arm act natural when holding tool in right arm. While there, I made it work vice versa! This also, funnily enough, fixed the flickering issue people had. Last thing I've done was make the 'dirty' value sensitive to being nil. If it's nil, it's gonna be false and no transforms will be performed. I assumed this may be critical later on so I added it.
Slightly more strict compliant while keeping code running the exact same way.
CakiiiOfficial
changed the title
CakiiiOfficial
changed the title
Made it more obvious and easier for developers using this module to tune this module's behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen that it has issues with R6 (really weird movement) and after tinkering, I couldn't find anything that could fix it. So next thing I've done was to add backwards compatibility and it worked out well. Now both R15 and R6 work in harmony :D
Another thing I've done was to make left arm act natural when holding tool in right arm. While there, I made it work vice versa! This also, funnily enough, fixed the flickering issue people had when holding tools.
Last thing I've done was make the 'dirty' value sensitive to being nil. If it's nil, it's gonna be false and no transforms will be performed. I assumed this may be critical later on so I added it.
Another small thing I've done was make FirstPerson script slightly more strict compliant and Config.lua easier to configure for developers using this module.