Update abi_check.py to support standalone tf-psa-crypto #229
+687
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Matkin <anton.matkin@arm.com>
Signed-off-by: Anton Matkin <anton.matkin@arm.com>
Signed-off-by: Anton Matkin <anton.matkin@arm.com>
Signed-off-by: Anton Matkin <anton.matkin@arm.com>
… now disallowed, changed to concrete jpake algorithm (with SHA256 hash) Signed-off-by: Anton Matkin <anton.matkin@arm.com>
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
…thout_heap Enable p192[k|r]1 curves which are disabled by default in tf-psa-crypto. This is required to get the proper test coverage otherwise there are tests in 'test_suite_psa_crypto_op_fail' that would never be executed. Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
Move the PAKE hash algorithm parameter into the alg id
tests: configuration-crypto: enable p192 curves in test_psa_crypto_without_heap
Return a const char* instead of taking a char* as an argument. This aligns us with the interface used in TF PSA Crypto. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Previously these tests used values that will become PSA aliases, and so the tests will fail once they're changed. Signed-off-by: Felix Conway <felix.conway@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
Signed-off-by: Felix Conway <felix.conway@arm.com>
Signed-off-by: Felix Conway <felix.conway@arm.com>
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
Signed-off-by: Felix Conway <felix.conway@arm.com>
Signed-off-by: Felix Conway <felix.conway@arm.com>
Add more detail around how generation of configuration-independent files chooses a C compiler. Mention that setting HOSTCC or CC is recommended where there are multiple toolchains. Mention that the fallback location is the cc executable, which may help users troubleshooting when the file generation picks up the wrong toolchain (as in Mbed-TLS/mbedtls#10360). Signed-off-by: David Horstmann <david.horstmann@arm.com>
…PTO_RNG_HASH Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
…tion-cc Clarify use of `CC` and friends for file generation
Remove all references to MBEDTLS_ECDSA_DETERMINISTIC from components-configuration-crypto.sh. Replace them with PSA_WANT_ALG_DETERMINISTIC_ECDSA. This is safe because: * MBEDTLS_ECDSA_DETERMINISTIC is only ever unset in components in order to avoid errors from disabling its dependency MBEDTLS_HMAC_DRBG_C. * MBEDTLS_ECDSA_DETERMINISTIC is only ever defined in config_adjust_legacy_from_psa.h, and only if PSA_WANT_ALG_DETERMINISTIC_ECDSA is defined. Therefore PSA_WANT_ALG_DETERMINISTIC_ECDSA's dependencies are a superset of MBEDTLS_ECDSA_DETERMINISTIC's dependencies and must include MBEDTLS_HMAC_DRBG_C, so disabling PSA_WANT_ALG_DETERMINISTIC_ECDSA is a sufficient substitute for disabling MBEDTLS_ECDSA_DETERMINISTIC. Signed-off-by: David Horstmann <david.horstmann@arm.com>
…ent directory CMakeLists.txt file Signed-off-by: Felix Conway <felix.conway@arm.com>
Signed-off-by: Anton Matkin <anton.matkin@arm.com>
…ograms Signed-off-by: Anton Matkin <anton.matkin@arm.com>
Signed-off-by: Felix Conway <felix.conway@arm.com>
Signed-off-by: Felix Conway <felix.conway@arm.com>
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
…o_rng_hash crypto_config: Introduce MBEDTLS_PSA_CRYPTO_RNG_HASH (2/4)
gilles-peskine-arm
added
needs-work
and removed
needs-reviewer
bensze01
added
needs-review
bensze01
force-pushed
the
abicheck-port
branch
3 times, most recently
from
e9986c6 to
4179d1c
Compare
5 tasks
Contributor
|
I am trying to understand the history of this branch. Is that a merge of a feature branch into development? Even though the diff's make sense, this is pulling 1282 commits from a branch that is partially based on development ? |
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Argparse generally uses a return code of 2 for these situations. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
The same library may be present in the same build tree, eg. libtfpsacrypto.so, which gets copied from the tf-psa-crypto/core/ to library/ during an Mbed TLS build. Make sure that the duplicated libraries are byte-for-byte identical, otherwise abort the test. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
No functional changes. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
The only value that depended on us being in the project root was repo_path. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
The actual scripts will continue to live in the individual repositories. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
The default formatter coalesces all whitespace and reflows the text. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Use `find` to sort scripts/abi_check.py into a separate invocation of pylint. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
bensze01
force-pushed
the
abicheck-port
branch
from
4179d1c to
12fe6e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move abi_check.py to the framework, and update it to support a standalone tf-psa-crypto
PR checklist