Skip to content

Only clean CMake artifacts in-tree #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gilles-peskine-arm wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Only clean CMake artifacts in-tree #253

gilles-peskine-arm wants to merge 2 commits into from
+30 −19

Conversation

@gilles-peskine-arm
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm commented Dec 10, 2025 •
edited
Loading

Remove a major annoyance for maintainers who use ninja. Fixes #252

PR checklist

  • TF-PSA-Crypto PR not required because: no product impact
  • development PR not required because: no product impact
  • 3.6 PR provided # | not required because: no product impact

@gilles-peskine-arm gilles-peskine-arm added bug Something isn't working needs-ci Needs to pass CI tests priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Dec 10, 2025
@gilles-peskine-arm
Only clean CMake artifacts in-tree
c42774a 
Don't recurse into every subdirectory: that also removed files from
out-of-tree builds that the user may have placed into subdirectories. With
make as the build tool, the cleanup is mostly recoverable, but with ninja as
the build tool, you have to manually run `cmake` again after running
`all.sh`.

Instead, look for things to clean only in directories managed by git.

This also has the benefit of not touching `**/Makefile` if there hasn't been
an in-tree CMake build.

Fixes Mbed-TLS#252

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm force-pushed the all.sh-cleanup-cmake-only-in-tree branch from 83d1d4d to c42774a Compare December 10, 2025 18:23
@gilles-peskine-arm
CMake artifacts cleanup: fix the new code on Ubuntu 16.04
f8c6997 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)

Projects

Non-roadmap pull requests
Status: In Development

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

all.sh breaks local build trees using cmake with ninja

1 participant

@gilles-peskine-arm