Open
Conversation
.., for consistency with the Controller GUI.
* Move "Num" line's channel type's textual representation into a tooltip on the new graphical representation. * Move remaining contents of "Num" line from line 3/3 to being part of line 1/3 "Ch" (channel & published name). There is more to come for that line. * Split off published channel name into its own line 2/3, as it has frequently been a problem for me that, when the channel name becomes too long, the published name edit box gets moved "behind" the scroll bar and becomes mostly unuseable. * Move "Pos" line down (to line 3/3) accordingly.
* Instead of dumping not-easily-digested block positions to the player, count local/remote Controllers up from 1. Have the block position still available, as tooltip on a new Controller icon before the new Controller short name/number. This could probably be much improved by using the consumer/connector/ network numbers (and/or cable colours), but I currently don't know how to retrieve them. This would increase perceived interoperability with heads-up displays that already give such information when looking at the relevant block. * As we have the position in the tooltip now, plus a replacement for identity checking, get rid of the "Pos" line altogether, so we have only 2 lines per channel, now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to improve the Router GUI: Get away with cryptic block coordinates & channel indices, count up Controller numbers and use 1-based channel numbers that correspond to the Controller GUI, instead.
The head commit is only meant as a suggestion, but everything up to it seem reasonable to me.
Before:
After 8d1b9ca:
After 9e9df43:
Please bear with me as this is the first time I've coded for a Minecraft mod.