Fix PyPI and kokkos on m1#427
Merged
dannys4 merged 21 commits intoMeasureTransport:mainfrom Dec 3, 2025
Merged
Conversation
Contributor
dannys4
commented
Nov 4, 2025
dannys4
commented
- We didn't constrain versions of ninja and cmake which has become a problem if installing via pip.
- some issue happens now for kokkos <4.5 so I just changed the default version in cmake.
Contributor
Author
|
sorry for auto linting |
mparno
approved these changes
Dec 3, 2025
Contributor
mparno
left a comment
mparno
left a comment
There was a problem hiding this comment.
Thanks Danny! Sorry for the slow response on my end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.