Add message title for Google Cloud Messge (GCM)#1
Add message title for Google Cloud Messge (GCM)#1johnroyer wants to merge 4 commits intoMedAppNL:masterfrom
Conversation
|
First of all, thanks! I think it makes sense to have the So that you do not have to do that much runtime checking of the types. |
|
The library now supports 'title' and 'content' in stead of 'message'. There is not really a reason in Android to support only 2 types of data. It would be better to make this more flexibel so that users of the library can choose what to send and add for example an image url. |
|
@nickygerritsen: I add definition in Can you review this change for me? Thanks. |
|
@renefloor: I know that GCM and APNS now support custom data / field. It is a lot of works to do before we support custom data into Push service. How about open a issue to figure out a better way ? |
|
@johnroyer I opened an issue so it won't be lost over time. |
iOS app does not support message title, but Android can.
I add message title in
GooglePushService.phpand change work flow in methodsend()to set title for Android message.I've test on Sony mobile. May need some help testing on other devices.
Thanks