Skip to content

Webui optimization pass 01#32

Merged
MerverliPy merged 2 commits into
mainfrom
webui-optimization-pass-01
Jul 8, 2026
Merged

Webui optimization pass 01#32
MerverliPy merged 2 commits into
mainfrom
webui-optimization-pass-01

Conversation

@MerverliPy

@MerverliPy MerverliPy commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Description

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 Code style / refactoring (no functional changes)
  • 🔧 Configuration / build / CI changes
  • ⚡ Performance improvement
  • ✅ Test coverage improvement

Phase Context

  • Part of Phase implementation: Phase ___ — _________
  • Phase-independent (refactor, fix, polish, or tooling)

Exit gates addressed: (if applicable)

  • Exit gate 1: ...
  • Exit gate 2: ...

Testing

  • All existing tests pass (bun test)
  • New tests added for this change
  • Manual testing performed (describe scenarios below)

Test coverage:

# Commands to verify this change
bun test <package>

Checklist

  • My code follows the style guidelines (Biome passes)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Phase Verification (if applicable)

  • Exit gates updated in docs/27_PROJECT_ROADMAP.md (mark [x] when complete)
  • Phase status updated in AGENTS.md (if phase boundary changed)
  • Phase status updated in README.md (if phase boundary changed)
  • Test count badge updated in README.md (if tests added)

Documentation Updates

  • README.md
  • AGENTS.md
  • CONTRIBUTING.md
  • Roadmap doc (docs/27_PROJECT_ROADMAP.md)
  • API documentation
  • Inline code comments
  • N/A — no documentation changes needed

Related Issues

Fixes #
Relates to #

Screenshots / Videos (if applicable)

Deployment Notes

  • No special deployment steps required
  • Database migration required
  • Configuration changes required (specify below)
  • Environment variables added/changed (document in .env.example)

Reviewer Notes:

…and componentize dashboard

- Extract monolithic SSE handleEvent from App.tsx into lib/event-dispatcher.ts
- Replace synchronous onScroll with IntersectionObserver in ChatView.tsx
- Add keyboard focus traps to NavDrawer and PermissionPrompt
- Centralize SVG icons into components/icons/index.tsx, fix TabBar role=tablist
- Break monolithic dashboard App.tsx into Header, SummaryCards, StatusBreakdown, LatencyHeatmap, CostTrends
- Make root shell layout responsive (drop hardcoded 430px max-width)
- Fix permission.test.ts assertions to scan new dispatcher file

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 agent-workbench PR Review

✅ Clean — no issues found across 16 TypeScript files

📄 apps/dashboard/src/App.tsx

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

📄 apps/dashboard/src/components/CostTrends.tsx

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

📄 apps/dashboard/src/components/Header.tsx

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

📄 apps/dashboard/src/components/LatencyHeatmap.tsx

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

📄 apps/dashboard/src/components/StatusBreakdown.tsx

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

📄 apps/dashboard/src/components/SummaryCards.tsx

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

📄 apps/dashboard/src/utils/format.ts

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

📄 apps/mobile-web/src/App.tsx

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

📄 apps/mobile-web/src/components/ChatView.tsx

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

📄 apps/mobile-web/src/components/NavDrawer.tsx

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

📄 apps/mobile-web/src/components/PermissionPrompt.tsx

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

📄 apps/mobile-web/src/components/TabBar.tsx

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

📄 apps/mobile-web/src/components/icons/index.tsx

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

📄 apps/mobile-web/src/lib/event-dispatcher.ts

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

📄 apps/mobile-web/src/state/permission.test.ts

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

📄 benchmarks/e2e-skill-metrics.ts

  • ⚠️ WARNING [workbench]: File not found locally — may need to checkout the branch

@MerverliPy MerverliPy merged commit be9ed7f into main Jul 8, 2026
9 of 10 checks passed
@MerverliPy MerverliPy deleted the webui-optimization-pass-01 branch July 8, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant