Record Depot phase metrics - #22
Conversation
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe release workflow now records and uploads JSON measurements for native packaging, dry-image builds, and staged-image builds. Tests validate the evidence fields and retention settings. Documentation defines the execution matrix and Depot tuning boundaries. ChangesDepot telemetry
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant PackageImageWorkflow
participant Depot
participant GitHubArtifactStorage
PackageImageWorkflow->>Depot: Run package, dry-image, and staged-image phases
Depot-->>PackageImageWorkflow: Return build and project metadata
PackageImageWorkflow->>GitHubArtifactStorage: Upload phase measurement JSON
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/package-image-row.yml:
- Line 196: The package-image workflow currently stringifies runner labels when
passing them to record-generation steps. Update RUNNER_LABEL and the
native-package, dry-image, and staged-image records to use JSON passthrough and
emit runner.labels as an array. Apply the corresponding workflow assertions or
fixtures in tests/release-workflow.test.ts so all affected records preserve the
original JSON array.
In `@docs/matrix.md`:
- Around line 56-79: Add a distinct statement in docs/matrix.md documenting
macOS GPU/runtime limitations, separate from the Linux package/image execution
flow described in the “Execution and tuning boundary” section. Keep the existing
Linux behavior and matrix details unchanged, and avoid implying that macOS
GPU/runtime support uses the container packaging pipeline.
In `@tests/release-workflow.test.ts`:
- Around line 106-134: Update the test named “each Depot phase emits bounded
tuning evidence without claiming unavailable metrics” to assert that every Depot
phase preserves runner labels as a JSON-array field and uses the jq --argjson
input path. Add these assertions inside the existing per-job loop, alongside the
other measurement-record checks, without changing the existing metric
expectations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b736e57f-5d2f-42ef-9523-61f8dddf02ce
📒 Files selected for processing (4)
.github/workflows/package-image-row.ymldocs/matrix.mddocs/runner-capacity.mdtests/release-workflow.test.ts
Summary
Validation
node --experimental-strip-types --test tests/release-workflow.test.tsnode --experimental-strip-types scripts/image-matrix.ts validateactionlint .github/workflows/package-image-row.ymlgit diff --checkThis PR intentionally adds measurement rather than speculative runner or concurrency tuning.
Summary by CodeRabbit
New Features
Documentation
Tests