Modify METPlus apps to facilitate using at multiple sites#1906
Merged
Modify METPlus apps to facilitate using at multiple sites#1906
Conversation
Contributor
|
|
JorgeBornemann
commented
Feb 11, 2026
src/CSET/cset_workflow/app/metplus_ascii2nc/file/python/read_ascii_point.py
Outdated
Show resolved
Hide resolved
JorgeBornemann
commented
Feb 11, 2026
src/CSET/cset_workflow/app/metplus_ascii2nc/file/ASCII2NC_python_embedding.conf
Outdated
Show resolved
Hide resolved
JorgeBornemann
commented
Feb 11, 2026
JorgeBornemann
commented
Feb 11, 2026
JorgeBornemann
commented
Feb 11, 2026
JorgeBornemann
commented
Feb 11, 2026
JorgeBornemann
changed the title
Collaborator
Author
|
must be merged concurrently with https://github.com/MetOffice/CSET-restricted-files/pull/216 |
Sylviabohnenstengel
approved these changes
Feb 11, 2026
Member
Sylviabohnenstengel
left a comment
Sylviabohnenstengel
left a comment
There was a problem hiding this comment.
happy to approve though suggest that @jfrost-mo has a further technical look through
jfrost-mo
changed the title
jfrost-mo
reviewed
Feb 12, 2026
Member
jfrost-mo
left a comment
jfrost-mo
left a comment
There was a problem hiding this comment.
A few minor suggestions; the main one is to use isodatetime for parsing the forecast duration into hours. Otherwise looks good and happy to merge.
jfrost-mo
approved these changes
Feb 18, 2026
Member
jfrost-mo
left a comment
jfrost-mo
left a comment
There was a problem hiding this comment.
Looking good. I'll go ahead and merge this along with the corresponding PR in the restricted repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #971. This PR restores MET functionality at NIWA after migration to new HPC and changes in the bake tasks schedulling, it also sets the infrastructure to start adding other site-specific METPlus configurations,
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.