Skip slow tests in CI, only running them weekly#1914
Merged
Conversation
These tests represent a significant fraction of the total testing time. To reduce the burden of slow tests they are being marked so they can be skipped.
make test-fast also skips network tests, for use in CI. make test-full is for running all the tests, and will include the upcoming playwright tests.
The full test suite is now run in the weekly checks, as no one will have to wait for it then while still giving things a regular test.
jfrost-mo
added
cleanup
Contributor
|
|
daflack
approved these changes
Feb 18, 2026
Collaborator
daflack
left a comment
daflack
left a comment
There was a problem hiding this comment.
Happy with this change, and is really beneficial to allow the rapid development that we are in at the moment. One thing that might be worth doing is adding documentation on make test and the new options at some point, but I view this as a separate PR as it hasn't been done beforehand so is not just a case of updating it.
Member
Author
|
That's a solid call. I'll add something to the developer documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This significantly speeds up our per-commit/pull request tests while ensuring slow things are still tested at least weekly.
Slow tests were determined with
pytest --durations, with any test taking over 2 seconds on my local machine marked as slow.As a point of comparison, the py314 tests went from 1m17s before this change to 40s afterwards, a nearly 2x speedup.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.