Skip to content

Revert "Adds capability to get last time in file for validity time and updates"#1916

Merged
daflack merged 1 commit intomainfrom
revert_less_than_or_equal_in_fetch
Feb 18, 2026
Merged

Revert "Adds capability to get last time in file for validity time and updates"#1916
daflack merged 1 commit intomainfrom
revert_less_than_or_equal_in_fetch

Conversation

@jfrost-mo
Copy link
Member

This reverts commit d77cb8a.

Times and bounds really are confusing. The actual issue we were seeing was due to initiation time being selected rather than validity time.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jfrost-mo jfrost-mo added this to the CSET v26.2.0 milestone Feb 18, 2026
@jfrost-mo jfrost-mo requested a review from daflack February 18, 2026 15:53
@jfrost-mo jfrost-mo self-assigned this Feb 18, 2026
@jfrost-mo jfrost-mo added bug Something isn't working small Small issue that should be quick to resolve labels Feb 18, 2026
@jfrost-mo jfrost-mo marked this pull request as ready for review February 18, 2026 15:55
@github-actions
Copy link
Contributor

Coverage

Copy link
Collaborator

@daflack daflack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with these changes.

@daflack daflack merged commit 0336661 into main Feb 18, 2026
8 checks passed
@daflack daflack deleted the revert_less_than_or_equal_in_fetch branch February 18, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working small Small issue that should be quick to resolve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments