Lfric2lfric: interpolate W2 fields#238
Open
ukmo-juan-castillo wants to merge 9 commits intoMetOffice:mainfrom
Open
Lfric2lfric: interpolate W2 fields#238ukmo-juan-castillo wants to merge 9 commits intoMetOffice:mainfrom
ukmo-juan-castillo wants to merge 9 commits intoMetOffice:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @mike-hobson
Code Reviewer: @TeranIvy
This is relatively simple change to allow lfric2lfric to regrid W2 fields. The accepted procedure to deal with W2 is to convert them to a set of two W3 and one Wtheta fields, process these fields, and then regenerate back a W2 field with the resulting W3 and Wtheta fields.
This changes will make use of the existing subroutines converting W2 to W3,Wtheta fields, and back.
Code Quality Checklist
Testing
No new tests were deemed necessary. The changes will necessary change KGOs, because now W2 fields will be processed, but no changes are expected in other fields.
trac.log
Test Suite Results - lfric_apps - lfric2lfric_W2/run3
Suite Information
Task Information
✅ succeeded tasks - 1461
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review