Swap apps to use to config_loader_mod instead of configuration_mod#239
Swap apps to use to config_loader_mod instead of configuration_mod#239mo-rickywong wants to merge 3 commits intoMetOffice:mainfrom
Conversation
|
Hello @mo-rickywong! 👋 Thank you for your contribution. Since this is your first time contributing to this repository, we ask that you sign our Contributor Licence Agreement (CLA). To agree to the CLA, please add your details (GitHub username, Real Name, Affiliation, and Date) to the CONTRIBUTORS.md file (create one, if required) in the development branch for this PR. After signing the CLA, you won't need to do this again for future PRs. |
|
This change does alter some jedi files, a JEDI PR may be required |
ss421
left a comment
There was a problem hiding this comment.
The change here does not appear to effect applications and is used by integration and unit tests only. We should not be impacted by this.
svadams
left a comment
There was a problem hiding this comment.
Straightforward changes that look fine to me. Approving for merge
PR Summary
Sci/Tech Reviewer: N/A technical clean-up, straight replace on lots of files
Code Reviewer: @svadams
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - SwapToConfigLoader/run5
Suite Information
Task Information
✅ succeeded tasks - 1111
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review