Plumbing in adjoint lookup table caches to interface

[DrTVockerodtMO]

PR Summary

Sci/Tech Reviewer: @odlomax
Code Reviewer: @jennyhickson

Lengthy but basic changeset which plumbs the adjoint lookup table caches into the interface, i.e.: the second part of #72 . Unfortunately this touches many files because the caches are used at the lowest levels of the transport/solver adjoint trees, but the changeset is very repetitive and is mainly interface changes.

• fixes Plumb adjoint lookup table caches into interface #93

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Apps rose-stem suite
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - lfric_apps_adjoint_lookup_cache_part_2_branch_2/run2

Suite Information

Item	Value
Suite Name	lfric_apps_adjoint_lookup_cache_part_2_branch_2/run2
Suite User	terence.vockerodt
Workflow Start	2026-02-17T14:25:52
Groups Run	developer

Dependency	Reference	Main Like
casim	MetOffice/casim@2025.12.1	True
jules	MetOffice/jules@69aaf4d	True
lfric_apps	DrTVockerodtMO/lfric_apps@origin/lfric_apps_adjoint_lookup_cache_part_2_branch_2	False
lfric_core	MetOffice/lfric_core@88533c5	True
moci	MetOffice/moci@2025.12.1	True
SimSys_Scripts	MetOffice/SimSys_Scripts@2025.12.1	True
socrates	MetOffice/socrates@2025.12.1	True
socrates-spectral	MetOffice/socrates-spectral@2025.12.1	True
ukca	MetOffice/ukca@2025.12.1	True

Task Information

❌ failed tasks - 17

Task	State
check_linear_model_nwp_gal9-C12_MG_azspice_gnu_production-32bit	failed
check_linear_model_nwp_gal9-C12_MG_ex1a_cce_fast-debug-32bit	failed
check_linear_model_nwp_gal9-C12_MG_ex1a_cce_production-32bit	failed
check_linear_model_nwp_gal9-C12_MG_ex1a_gnu_fast-debug-32bit	failed
check_linear_model_nwp_gal9-C12_MG_ex1a_gnu_full-debug-32bit	failed
check_linear_model_nwp_gal9-C12_MG_ex1a_gnu_production-32bit	failed
kgo_groups_checker	failed
run_jedi_lfric_tests_tlm_tests_nwp_gal9-1PE-4OMP-C12_MG_ex1a_cce_fast-debug-64bit	failed
run_jedi_lfric_tests_tlm_tests_nwp_gal9-1PE-C12_MG_ex1a_cce_fast-debug-64bit	failed
run_jedi_lfric_tests_tlm_tests_nwp_gal9-4OMP-C12_MG_ex1a_cce_fast-debug-64bit	failed
run_jedi_lfric_tests_tlm_tests_nwp_gal9-C12_MG_ex1a_cce_fast-debug-64bit	failed
run_jedi_lfric_tests_tlm_tests_nwp_gal9-dry-1PE-4OMP-C12_MG_ex1a_cce_fast-debug-64bit	failed
run_jedi_lfric_tests_tlm_tests_nwp_gal9-dry-1PE-C12_MG_ex1a_cce_fast-debug-64bit	failed
run_jedi_lfric_tests_tlm_tests_nwp_gal9-dry-4OMP-C12_MG_ex1a_cce_fast-debug-64bit	failed
run_jedi_lfric_tests_tlm_tests_nwp_gal9-dry-C12_MG_ex1a_cce_fast-debug-64bit	failed
run_jedi_lfric_tests_tlm_tests_nwp_gal9-real_increment-4OMP-C12_MG_ex1a_cce_fast-debug-64bit	failed
run_jedi_lfric_tests_tlm_tests_nwp_gal9-strict_solver-4OMP-C12_MG_ex1a_cce_fast-debug-64bit-rsolver64	failed

✅ succeeded tasks - 1150

⌛ waiting tasks - 2

Task	State
housekeep_azspice	waiting
housekeep_ex1a	waiting

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[DrTVockerodtMO]

@cjohnson-pi I am currently running the test-suite and am getting linear KGO failures, none of these changes touch the linear (only the adjoint).

The ones that are failing are:
check_linear_model_nwp_gal9-C12_MG_azspice_gnu_production-32bit
check_linear_model_nwp_gal9-C12_MG_ex1a_gnu_fast-debug-32bit
check_linear_model_nwp_gal9-C12_MG_ex1a_gnu_full-debug-32bit
check_linear_model_nwp_gal9-C12_MG_ex1a_gnu_production-32bit
check_linear_model_nwp_gal9-C12_MG_ex1a_cce_production-32bit
check_linear_model_nwp_gal9-C12_MG_ex1a_cce_fast-debug-32bit

64bit tests are passing, I'll check to see if I have the correct KGOs.

[DrTVockerodtMO]

@cjohnson-pi I am currently running the test-suite and am getting linear KGO failures, none of these changes touch the linear (only the adjoint).

The ones that are failing are: check_linear_model_nwp_gal9-C12_MG_azspice_gnu_production-32bit check_linear_model_nwp_gal9-C12_MG_ex1a_gnu_fast-debug-32bit check_linear_model_nwp_gal9-C12_MG_ex1a_gnu_full-debug-32bit check_linear_model_nwp_gal9-C12_MG_ex1a_gnu_production-32bit check_linear_model_nwp_gal9-C12_MG_ex1a_cce_production-32bit check_linear_model_nwp_gal9-C12_MG_ex1a_cce_fast-debug-32bit

64bit tests are passing, I'll check to see if I have the correct KGOs.

It looks like I have the right KGOs, not sure what this issue is...

[DrTVockerodtMO]

@ss421 I also get some failures in jedi_lfric_tests on ex1a, most of the NWP tests fail in what I presume is the non-linear run on timestep 11. Is this a known problem? They pass on azspice.

[james-bruten-mo]

Hi Terry, The linear_model kgo failures are an issue on main which'll be fixed this morning. I suspect they weren't updated successfully before being merged yesterday.
The jedi_lfric_tests jobs all passed last night however

[DrTVockerodtMO]

Hi Terry, The linear_model kgo failures are an issue on main which'll be fixed this morning. I suspect they weren't updated successfully before being merged yesterday. The jedi_lfric_tests jobs all passed last night however

Thanks for that James, that helps narrow it down at least!

[james-bruten-mo]

Sorry - clicked the wrong button there!