Delete Jules metadata copy#463
Open
James Bruten (james-bruten-mo) wants to merge 7 commits intoMetOffice:mainfrom
Open
Delete Jules metadata copy#463James Bruten (james-bruten-mo) wants to merge 7 commits intoMetOffice:mainfrom
James Bruten (james-bruten-mo) wants to merge 7 commits intoMetOffice:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: Maggie (@maggiehendry)
Code Reviewer: Sam Clarke-Green (@t00sa)
This deletes lfric-jules-shared and jules-lfric metadata sections from lfric_apps now that the build system can extract the metadata from jules.
The metadata deleted is either already in, or has been copied to the Jules repo. Older versions are renamed to match Jules versions, with corresponding imports updated here.
Code Quality Checklist
Testing
As well as rose-stem testing, I've also tested that the changes to apply_macros and release_new_version in the linked PR also work by creating new Jules and LFRic releases on test branches. I've then used the metadata in these test branches to update an lfric_apps suite to ensure it will upgrade from vn3.1 to vn3.2 correctly. This all works as expected.
trac.log
Test Suite Results - lfric_apps - apps_delete_jules_meta/run2
Suite Information
Task Information
✅ succeeded tasks - 1185
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review