Lift adjustable psyclone command options into adjustable flag#271
Merged
harry-shepherd merged 4 commits intoMetOffice:mainfrom Feb 16, 2026
Merged
Conversation
Merged
28 tasks
Contributor
Author
|
In the short term, users should be able to override |
andrewcoughtrie
requested changes
Feb 12, 2026
Collaborator
andrewcoughtrie
left a comment
There was a problem hiding this comment.
The implementation is fine with me, the only thing to fix is the tabs and spaces used on the new lines as they don't align with the other lines.
Contributor
Author
|
I've adjusted the tabbing to align exactly with the lines above. I'll have a look at the apps ticket. |
andrewcoughtrie
approved these changes
Feb 12, 2026
Collaborator
andrewcoughtrie
left a comment
There was a problem hiding this comment.
That all looks fine now.
This was referenced Feb 12, 2026
harry-shepherd
approved these changes
Feb 16, 2026
Contributor
Author
|
Docs updated here: MetOffice/lfric_apps#261 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
For PSyKAl command makefile.
This issue MetOffice/simulation-systems#574 has requested the ability to adjust the line length for the Transmute command due to compiler issues at their site.
We have agreed to also modify the PSyKAl command in the same way.
-l all seems to be the only option that should be overridable.
Users should be able to use this variable, but privatised for a file by file basis, though this has not yet been explored.
Twin but not linked Apps change PR: MetOffice/lfric_apps#246
Sci/Tech Reviewer: @andrewcoughtrie
Code Reviewer: @harry-shepherd
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - psyclone_command_flags_override/run1
Suite Information
Task Information
✅ succeeded tasks - 382
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review