-
Notifications
You must be signed in to change notification settings - Fork 14
Update release instructions #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+84
−0
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| .. ----------------------------------------------------------------------------- | ||
| (c) Crown copyright Met Office. All rights reserved. | ||
| The file LICENCE, distributed with this code, contains details of the terms | ||
| under which the code may be used. | ||
| ----------------------------------------------------------------------------- | ||
|
|
||
| .. _milestones: | ||
|
|
||
| Milestones and Projects | ||
| ======================= | ||
|
|
||
| #. Tidy up all pull requests and issues for the completed milestone in the | ||
| Simulation Systems Review and Issues Trackers. | ||
|
|
||
| .. code-block:: shell | ||
|
|
||
| python SimSys_Scripts/gh_review_project/finish_milestone.py --milestone="<milestone title>" | ||
|
|
||
| with optional argument ``--dry`` to dry run the changes. | ||
|
|
||
| The script will prompt for you to continue after checking all PRs and issues | ||
| are in a suitable state. If it flags items that need correcting then go to | ||
| `Simulation Systems Review Tracker`_ and | ||
| `Simulation Systems Issue Tracker`_ to manually sort them. | ||
|
|
||
| #. As prompted by the above script, close the current milestone using: | ||
|
|
||
| .. code-block:: shell | ||
|
|
||
| ./SimSys_Scripts/sbin/gh_manage_milestones -t <title of milestone> -m close | ||
|
|
||
| #. Open the next new milestone so that there are the same number of open milestones: | ||
|
|
||
| .. code-block:: shell | ||
|
|
||
| ./SimSyS_Scripts/sbin/gh_manage_milestones -t <title> -d YYYY-MM-DDTHH:MM:SSZ -p <description> | ||
|
|
||
| * the title is ``Spring YYYY``, ``Summer YYYY`` or ``Autumn YYYY`` | ||
| * the date is the first Wednesday in March, July or November | ||
| * the description is ``Code Review deadline is <date> (SciTech review to be completed by this date)`` | ||
| selecting a Friday at the end of January/May/September for the deadline. | ||
|
|
||
| .. _Simulation Systems Review Tracker: https://github.com/orgs/MetOffice/projects/376 | ||
| .. _Simulation Systems Issue Tracker: https://github.com/orgs/MetOffice/projects/418 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth a note that this step can only be done by an admin (actually I might be wrong about that?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
milestones can be modified with write or maintainer permissions. I think leave it until someone hits an issue and then we can document it.