Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jan 6, 2026

Explanation

Remove network-controller dependency for chain-agnostic-permission as it brings in a massive amount of dependencies and is only used for a single type union that contains string anyway.

The additional dependencies becomes hard to manage when using chain-agnostic-permission outside a MetaMask client (e.g. in Snaps).


Note

Removes the @metamask/network-controller dependency and eliminates its type usage.

  • Drops @metamask/network-controller from package.json and yarn.lock
  • Updates caip25Permission.ts to remove the import and change findNetworkClientIdByChainId return type from NetworkClientId to string
  • Notes the change in CHANGELOG.md

Written by Cursor Bugbot for commit 36a8356. This will update automatically on new commits. Configure here.

@FrederikBolding FrederikBolding changed the title fix: Remove network-controller dependency for chain-agnostic-permission chore: Remove network-controller dependency for chain-agnostic-permission Jan 6, 2026
@FrederikBolding FrederikBolding changed the title chore: Remove network-controller dependency for chain-agnostic-permission chore: Remove network-controller dependency for chain-agnostic-permission Jan 6, 2026
@FrederikBolding FrederikBolding marked this pull request as ready for review January 6, 2026 14:42
@FrederikBolding FrederikBolding requested review from a team as code owners January 6, 2026 14:42

### Changed

- Remove `@metamask/network-controller` dependency ([#7561](https://github.com/MetaMask/core/pull/7561))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be in a Removed section? Doesn't really matter though

@FrederikBolding FrederikBolding added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit ac4cd76 Jan 6, 2026
286 checks passed
@FrederikBolding FrederikBolding deleted the fb/remove-network-controller-dep-for-caip25 branch January 6, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants