chore: Remove network-controller dependency for chain-agnostic-permission
#7561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Remove
network-controllerdependency forchain-agnostic-permissionas it brings in a massive amount of dependencies and is only used for a single type union that containsstringanyway.The additional dependencies becomes hard to manage when using
chain-agnostic-permissionoutside a MetaMask client (e.g. in Snaps).Note
Removes the
@metamask/network-controllerdependency and eliminates its type usage.@metamask/network-controllerfrompackage.jsonandyarn.lockcaip25Permission.tsto remove the import and changefindNetworkClientIdByChainIdreturn type fromNetworkClientIdtostringCHANGELOG.mdWritten by Cursor Bugbot for commit 36a8356. This will update automatically on new commits. Configure here.