Skip to content

Conversation

@github-actions
Copy link
Contributor

This is the release candidate for version 6.0.1.

@legobeat legobeat marked this pull request as ready for review August 20, 2024 23:46
@legobeat legobeat requested a review from a team as a code owner August 20, 2024 23:46
Gudahtt
Gudahtt previously approved these changes Jan 14, 2025
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt dismissed their stale review January 14, 2025 18:21

Discovered missing entries

@Gudahtt
Copy link
Member

Gudahtt commented Jan 14, 2025

This PR is not documented in the changelog: #81

@cryptodev-2s could you write a change entry for this? The PR doesn't seem to include one

@cryptodev-2s
Copy link
Contributor

This PR is not documented in the changelog: #81

@cryptodev-2s could you write a change entry for this? The PR doesn't seem to include one

No update to the CHANGELOG is necessary for this change, as we only updated a test file. Apologies for the confusion— the commit message is misleading.

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Copy link
Member

Gudahtt commented Jan 14, 2025

Oh I see, thanks, sorry I misread the PR

github-actions and others added 2 commits January 14, 2025 15:09
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The other three changes seem non-functional

@Gudahtt Gudahtt merged commit e45d751 into main Jan 14, 2025
24 checks passed
@Gudahtt Gudahtt deleted the release/6.0.1 branch January 14, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants