fix: Eliminate flaky GC test race condition #756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the intermittent failures in the "should trigger GC syscalls through bringOutYourDead" test by adding proper synchronization.
Changes
await waitUntilQuiescent()afterqueueMessageto ensure all async syscall side-effects complete before checking reference countsRoot Cause
The test was flaking due to a race condition where reference count updates from
resolvePromisessyscalls were still pending in microtasks when the test immediately checked them afterawait kernel.queueMessage()returned.Verification
--repeat 10- all iterations passed🤖 Generated with Claude Code
Note
Synchronizes the GC test to eliminate a race when asserting reference counts.
garbage-collection.test.ts, addawait waitUntilQuiescent()immediately afterkernel.queueMessage('createObject', ...)in the "should trigger GC syscalls through bringOutYourDead" testkernelStorerefcounts, reducing test flakinessWritten by Cursor Bugbot for commit 0216c9f. This will update automatically on new commits. Configure here.