-
-
Notifications
You must be signed in to change notification settings - Fork 23
chore: update a few dependencies #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Caution MetaMask internal reviewing guidelines:
|
chore: update site dependencies
4e0dcd8 to
6d148c0
Compare
| "packageManager": "yarn@4.9.1", | ||
| "engines": { | ||
| "node": ">=18.0.0" | ||
| "node": ">=22.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Deleted patch file still referenced in resolutions
The @noble/hashes patch file at .yarn/patches/@noble-hashes-npm-1.7.1-4106ab26c5.patch was deleted, but the resolutions field still references it for three version ranges. Yarn will fail when attempting to apply the non-existent patch during installation, breaking the build process.
| "eslint-plugin-prettier": "^4.2.1", | ||
| "eslint-plugin-promise": "^6.1.1", | ||
| "prettier": "^2.2.1", | ||
| "prettier": "^3.5.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Incompatible Prettier and eslint-plugin-prettier versions
The snap package updated prettier to ^3.5.3 but kept eslint-plugin-prettier at ^4.2.1. Prettier 3.x introduced breaking API changes that require eslint-plugin-prettier version 5.x or higher. This mismatch will cause runtime errors when ESLint attempts to run Prettier, such as prettier.resolveConfig.sync is not a function.
|
No longer needed due to @ccharly 's PR |
Note
Upgrade Node to 22.8 and modernize tooling and Snap dependencies, plus snap config/manifest tweaks (localhost origin, platform v9.3).
v22.8.0(.nvmrc,engines.node) and upgrade package manager toyarn@4.9.1.eslint@^9, Prettier^3, TypeScript~5.8.3, and related ESLint configs/plugins; refresh lockfile.packages/snap):@metamask/keyring-api@^21.2.0,@metamask/keyring-snap-sdk@^7.1.0,@metamask/snaps-sdk@^9.3.0,@metamask/snaps-cli@^8.1.0.snap.config.ts: remove explicitbundler, addstats.builtIns.ignorelist.snap.manifest.json: addhttp://localhost:8000toallowedOrigins; bumpplatformVersionto9.3.0; updatesource.shasum.Written by Cursor Bugbot for commit 249fcc2. This will update automatically on new commits. Configure here.