Skip to content

Conversation

@himanshuchawla009
Copy link
Contributor

Motivation and Context

Jira Link:

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@himanshuchawla009 himanshuchawla009 marked this pull request as ready for review November 26, 2024 04:31

rpId?: string; // passkey, webauthn
}
export interface TorusUtilsExtraParams extends TorusUtilsPasskeyExtraParams {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just question,
can we use just add TorusUtilsPasskeyExtraParams as a field in TorusUtilsExtraParams ?

Suggested change
export interface TorusUtilsExtraParams extends TorusUtilsPasskeyExtraParams {
export interface TorusUtilsExtraParams {
passkeyParams: TorusUtilsPasskeyExtraParams

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good idea, we can do it in next breaking version. This change is not related to passkey linking. These are params for existing passkey/webauthn verifiers. I just divided it in seperate interface. We can do the change you are suggesting in next breaking version.

Copy link
Contributor

@ieow ieow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants