fix(action): make scan-path-not-found error event-aware and self-contained (#11)#47
Merged
Conversation
…ained Closes #11. The existing error message lists likely causes and links to the monorepo docs, but skims over two friction points: - On non-PR events ('push', 'workflow_dispatch', 'schedule') the default 'before-ref' is the parent commit, which frequently predates a freshly-added monorepo subdirectory. Users currently have to infer this from the 'before-ref' parenthetical; now the message says it outright with the event name. - The monorepo matrix recipe was a click away. For a build that failed mid-job, inlining the four-line snippet is faster than asking the user to leave the log. Also restates that bomdrift will not silently fall back to the repo root — DoD line 'keep the failure loud' — so a reader who only skims the bottom of the error still knows not to chase a 'maybe it'll just work' fix. Docs: adds a row to the troubleshooting table in docs/src/github-action.md mirroring the new shape so the symptom is greppable. 'bash -n entrypoint.sh' passes.
SBOM diffNo dependency changes. |
Coverage reportLine coverage: 84.1% (9381 / 11149 lines) Full lcov report available as workflow artifact coverage-lcov: download from this run. v0.9.8 introduces this report; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11.
Problem
When the action fails with
scan path not found: <dir>, the existing error skims over two friction points:pull_requestevents,GITHUB_WORKSPACEpoints at the merge-ref checkout, so a missing dir often means the PR doesn't actually touch that path — different cause thanpush/workflow_dispatch.Fix
pull_requestvspush/workflow_dispatch.Files
entrypoint.sh— event-aware branching + inline recipedocs/src/github-action.md— new troubleshooting row forscan path not found: <dir>Verification
bash -n entrypoint.sh✓