Pre-render Map Features as Cached RGBA Image#50
Merged
Conversation
…edundant patterns
…-plot into save_map_background
jansingl
approved these changes
Apr 17, 2026
jansingl
left a comment
jansingl
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for these improvements! The topography actually even looks nicer now.
The only thing I saw in the visual comparison that @pirmink sent me is that the top boundary of the map seems to be cut off. I don't know which part of the code causes this, and it is only cosmetics anyways.
Contributor
|
@leuty if you had an idea why the upper edge of the frame is missing and found a fix for this, I would wait with the merge, otherwise I'll merge it anyways as this glitch is nothing essential. |
Contributor
Author
|
Thanks for the review. The issue causing the clipping was a plus-minus-one error. The new solution should be more robust. Here is a png including the latest changes: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #49. When waling home I had the idea to cache the entire map background as this requires the least amount of changes. This is implemented in the first commit.
The rest are mostly drive-by cleanups and small fixes.
A quick timing showed about a 30% reduction in runtime.