Skip to content

Skip record variable from fof checks #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clairemerker merged 5 commits into from
May 27, 2026
Merged

Skip record variable from fof checks #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9a99c6
cleanup output and increase skip variables
huppd May 26, 2026
9848371
fix pytest
huppd May 26, 2026
2a90939
fix test
huppd May 26, 2026
b1b844f
revert unclean fix
huppd May 26, 2026
3fcef5e
revert other changes
huppd May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/util/test_fof_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,10 +249,8 @@ def test_compare_var_and_attr_ds(ds1, ds2):
)

total1, equal1 = compare_var_and_attr_ds(ds1, ds2, detailed_logger)
total2, equal2 = compare_var_and_attr_ds(ds1, ds2, detailed_logger)

assert (total1, equal1) == (103, 102)
assert (total2, equal2) == (103, 102)


@pytest.fixture(name="ds3")
Expand Down
2 changes: 1 addition & 1 deletion util/fof_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def compare_var_and_attr_ds(ds1, ds2, detailed_logger):
"""

total_all, equal_all = 0, 0
list_to_skip = ["source", "i_body", "l_body", "veri_data"]
list_to_skip = ["source", "i_body", "l_body", "veri_data", "record"]

for var in set(ds1.data_vars).union(ds2.data_vars):
if var in ds1.data_vars and var in ds2.data_vars and var not in list_to_skip:
Expand Down
Loading