Skip to content

Refactor rules#106

Merged
huppd merged 12 commits into
mainfrom
refactor_rules
Jun 17, 2026
Merged

Refactor rules#106
huppd merged 12 commits into
mainfrom
refactor_rules

Conversation

@huppd

@huppd huppd commented May 27, 2026

Copy link
Copy Markdown
Collaborator

The rules to allow mutliple values for integer variables in fof files have been reworked.

  • add type annotation for rules
  • transform str to rules dictionary at the cli level
  • add test for rules
  • add help text for rules option

@huppd huppd marked this pull request as ready for review June 8, 2026 12:40

@lxavier lxavier left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, is this change tested by the CI, if not can you add a comment on what you tested manually

Comment thread tests/engine/test_fof_compare.py
@huppd huppd merged commit 7bff70b into main Jun 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants