Allow float64#88
Merged
Merged
Conversation
huppd
reviewed
Jan 27, 2026
huppd
left a comment
huppd
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for these nice improvement. I am not sure how much of it is still needed with the other changes, so it is not very urgent right now.
Co-authored-by: Daniel Hupp <daniel.hupp@meteoswiss.ch>
Co-authored-by: Daniel Hupp <daniel.hupp@meteoswiss.ch>
huppd
approved these changes
May 22, 2026
huppd
left a comment
huppd
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the clean refactor — the NaN handling is now consistent and the naming is clearer. This looks good to me and is ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request ensures that float64 values are accepted and that no temporary files are created during the tests