Improved validation handling for Array of validation functions.#86
Open
ainesophaur wants to merge 1 commit intoMichaelCereda:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By inherently assuming the validation value is
true, failed validations would then be overridden by successful validations (or vise-versa)The proposed validation handler for an Array of validationFn assumes the validity is
undefineduntil it fails. If it reaches the end of the validationFns, then the result can be assumed to be true.The following return types will trigger validation to be false
ErrorreturnedfalsereturnedstringreturnedThere is also an additional propType for validationQuickBail which will short circuit validation if set and an previous error has been discovered.