fix: do not crash when looking at unknown nodes#1
Open
JakubVanek wants to merge 1 commit intoMightyAlex200:masterfrom
JakubVanek:bugfix/unknown-block-crash
Open
fix: do not crash when looking at unknown nodes#1JakubVanek wants to merge 1 commit intoMightyAlex200:masterfrom JakubVanek:bugfix/unknown-block-crash
JakubVanek wants to merge 1 commit intoMightyAlex200:masterfrom
JakubVanek:bugfix/unknown-block-crash
Conversation
"Unknown nodes" have real IDs, but they do not have corresponding registered node. This makes Minetest crash due to nil dereference in the describe_node() function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Unknown nodes" have real IDs, but they do not have corresponding registered node. This makes Minetest crash due to nil dereference in the describe_node() function.