feature: enable users to pass arrays to Decimal.sum#255
Open
hunterwilhelm wants to merge 1 commit intoMikeMcl:masterfrom
Open
feature: enable users to pass arrays to Decimal.sum#255hunterwilhelm wants to merge 1 commit intoMikeMcl:masterfrom
hunterwilhelm wants to merge 1 commit intoMikeMcl:masterfrom
Conversation
Owner
|
Hello. I'll consider this change, but I am uncomfortable with its inconsistency with other functions such as There is also the question of whether, for example, Also, this library is advertised as using ECMAScript 3 features only, and Thank you for doing a careful job with the docs, test, and types updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #230
A minor conflict with #254 will happen. By choosing "Accept Combination", it will easily be resolved, since the changed lines don't overlap, they are just close enough to trigger it.