Skip to content

[Fix] Complete exception handling when interrupt execution#1

Open
Droid-MAX wants to merge 1 commit intoMikeWang000000:mainfrom
Droid-MAX:main
Open

[Fix] Complete exception handling when interrupt execution#1
Droid-MAX wants to merge 1 commit intoMikeWang000000:mainfrom
Droid-MAX:main

Conversation

@Droid-MAX
Copy link

No description provided.

@MikeWang000000
Copy link
Owner

Thank you for your PR!

Printing a traceback on CTRL-C is the default behavior in Python. However, SystemExit does not produce a backtrace output by default.
I do not think there is a need to catch SystemExit.

Besides, since n4 does not perform a cleanup process, changing the exit code to zero does not seem like a good idea. I think we should keep the exit code be as it is.

Could you update your code solving above two small issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants