Skip to content

Comments

Including Ofx160.dtd as native option on SgmlReader#15

Open
olavorn wants to merge 6 commits intoMindTouch:masterfrom
olavorn:master
Open

Including Ofx160.dtd as native option on SgmlReader#15
olavorn wants to merge 6 commits intoMindTouch:masterfrom
olavorn:master

Conversation

@olavorn
Copy link

@olavorn olavorn commented Feb 16, 2016

This enables SgmlReader to use option "ofx" in a native way.

@lovettchris
Copy link

This is not really necessary, the user can always include the OFX.dtd in their own app. The only reason I included HTML in SgmlReader is because it is such a common use case.

@olavorn
Copy link
Author

olavorn commented Sep 13, 2016

I Agree @lovettchris ,

Anyway I think bringing this inside is a much more straightfoward way for those who are looking for an Ofx Reader (my case). :)

And in an architectural point of view, I expect the cases that this .dtd is shared with the rest of the application will be far from usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants