Add HELM ecosystem map generator#7
Conversation
|
Local validation passed in full workspace context. Remote CI runs repo-only validation with REQUIRE_WORKSPACE_CONTEXT=0 and keeps the full workspace ecosystem check as the local/default Makefile path. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17c89130d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @ruby -e 'require "yaml"; require "date"; YAML.safe_load(File.read("repo-manifest.yaml"), permitted_classes: [Date, Time], aliases: true); puts "validated repo-manifest.yaml"' | ||
| @ruby -e 'require "yaml"; require "date"; %w[manifest-local-policy.yaml local-compatibility-policy.yaml].each { |path| YAML.safe_load(File.read(path), permitted_classes: [Date, Time], aliases: true) }; puts "validated ecosystem map policies"' | ||
| @ruby -e 'require "yaml"; YAML.safe_load(File.read("agent.yaml"), aliases: true); YAML.safe_load(File.read("catalog-info.yaml"), aliases: true); YAML.safe_load(File.read("observability/alerts.yaml"), aliases: true); puts "validated baseline yaml"' | ||
| @ruby scripts/generate-helm-ecosystem-map.rb --check |
There was a problem hiding this comment.
In the checked workflow, .github/workflows/ci.yml only checks out this repository before invoking make lint, so this new lint step runs without sibling workspace repos such as production-readiness and docs_for_team. In that context scripts/generate-helm-ecosystem-map.rb --check requires /workspace/production-readiness/estate/estate-inventory.json and aborts before lint can pass, blocking every normal PR/push CI job unless the workflow checks out the full workspace or this check is gated to environments that have it.
Useful? React with 👍 / 👎.
| lines << "This file is generated. Do not edit it by hand." | ||
| lines << "" | ||
| lines << "> [!IMPORTANT]" | ||
| lines << "> `/Users/ivan/Code/Mindburn-Labs` is a polyrepo workspace, not one git repository. `.github-repo/repo-manifest.yaml` controls GitHub repo existence, visibility, and archive status. `production-readiness/estate/estate-inventory.json` controls local path classification only." |
There was a problem hiding this comment.
AGENTS.md explicitly says to use $MINDBURN_WORKSPACE_ROOT for workspace references and not hard-code Ivan's local path as a platform invariant. This generated notice bakes /Users/ivan/Code/Mindburn-Labs into every output document, so anyone regenerating the map gets a machine-specific path presented as the canonical workspace instead of the configured workspace root or variable reference.
Useful? React with 👍 / 👎.
|
Superseded by main: the ecosystem-map generator, manifest-local + compatibility policies, and refresh script already exist on main in a newer form (archived/deleted-repo handling, $MINDBURN_WORKSPACE_ROOT instead of a hardcoded path, current app-helm-console/app-docs-platform/app-mindburn-web source-of-truth table). Merging would regress main, so closing. |
1 participant
Summary
Validation