Fix CoroutineScope in MainViewModel fetchUser()

[captswag]

I was going through this blog article https://blog.mindorks.com/mvi-architecture-android-tutorial-for-beginners-step-by-step-guide and downloaded this repo to learn more about MVI.

Anyways, I found this error (sort of) in the MainViewModel fetchUser(). The problem here is fetchUser() is already called from a different CoroutineScope. So instead of launching a new viewModelScope, we can reuse the previous one. So the PR request I raised removes the viewModelScope.launch {} and instead makes the fetchUser() suspend.

[mirokolodii]

@captswag scope here is only one - viewModelScope, but within this scope several coroutines are launched. Each viewModelScope.launch launches a new coroutine within the same scope.
So in the code we have one coroutine, which is created to listen to new intents and it basically has the same lifecycle as ViewModel.
Then, inside this coroutine, a child coroutine is created to fetch users, which 'lives' only for a duration of this intent.
I would not say your proposal is not correct, but it's not a bug you're fixing, but rather introduction of different behavior.
In original code, new intent can be accepted while previous is still ongoing. This is because for 'users fetching' intent there is a new coroutine created, which can be suspended, while the parent coroutine continue operating and can accept new intents.
In your proposal, no new intent can be accepted until previous one is completed. This is because all work is done within single coroutine.