Skip to content

Add Kotlin Buildscripts + Add Kotlin Buildscript Support to Testing + Update Gradle Plugins, Gradle and MinecraftForge#6

Open
Codetoil wants to merge 8 commits intoMinecraftForge:masterfrom
Codetoil:master
Open

Add Kotlin Buildscripts + Add Kotlin Buildscript Support to Testing + Update Gradle Plugins, Gradle and MinecraftForge#6
Codetoil wants to merge 8 commits intoMinecraftForge:masterfrom
Codetoil:master

Conversation

@Codetoil
Copy link
Contributor

Lex mentioned that the Kotlin Buildscript needed to be added to the testing framework. I went ahead and did that.
While I was there, I bumped the Gradle Plugins, Gradle and MinecraftForge, since they should probably be up to date.

@LexManos
Copy link
Member

LexManos commented Mar 1, 2026

This doesnt actually seem to add any kotlin examples
Nore does it seem to of actually run the _internal updates.
What is the goal of this PR?

@Codetoil
Copy link
Contributor Author

Codetoil commented Mar 1, 2026

It adds the existing kotlin buildscript into the _internal testing framework. Plus I made some modifications to it to extend its capabilities.

@Codetoil
Copy link
Contributor Author

Codetoil commented Mar 1, 2026

If you want me to add the kotlin examples in the same PR, I could, but that'll take me some time to make.

@LexManos
Copy link
Member

LexManos commented Mar 1, 2026

Worth doing yes, and like I said, the updateBuilds task doesnt seem to of been run because the current projects output a range, which is not what the code does.
Jonathan changed things to a range after I wrote that task and never updated it.

@Codetoil
Copy link
Contributor Author

Codetoil commented Mar 1, 2026

I did actually run it though. I modified the task to output a range since that what I thought you wanted.

@LexManos
Copy link
Member

LexManos commented Mar 1, 2026

Oh my bad, forgot it was hardcoded, thought I had it pick from that subproject's version. Im an idiot.
I'll try and remember to look at this tomarrow. But yes, having a kotlin version of each example is the overall goal.

@Codetoil Codetoil marked this pull request as draft March 2, 2026 05:45
@Codetoil Codetoil changed the title Add Kotlin Buildscript Support to Testing + Update Gradle Plugins, Gradle and MinecraftForge Add Kotlin Buildscripts + Add Kotlin Buildscript Support to Testing + Update Gradle Plugins, Gradle and MinecraftForge Mar 2, 2026
@Codetoil Codetoil marked this pull request as ready for review March 2, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants